Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sharepoint convert data types to string #937

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Sharepoint convert data types to string #937

merged 4 commits into from
Jun 25, 2024

Conversation

Rafalz13
Copy link
Contributor

@Rafalz13 Rafalz13 commented Jun 25, 2024 •
edited
Loading

Summary

Added _convert_all_to_string_type and _empty_column_to_string to convert all types to string or object.

Importance

It was important to cast empty columns to string as the type of empty column was object. Pandas was showing the error.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Rafalz13 Rafalz13 requested a review from trymzet June 25, 2024 10:12
@Rafalz13 Rafalz13 requested a review from marcinpurtak June 25, 2024 11:21
@Rafalz13 Rafalz13 changed the title Sharepoint convert to string Sharepoint convert data types to string Jun 25, 2024
@trymzet trymzet merged commit 497f75e into 2.0 Jun 25, 2024
4 checks passed
@trymzet trymzet deleted the sharepoint_convert_to_string branch June 25, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trymzet trymzet trymzet approved these changes

@marcinpurtak marcinpurtak Awaiting requested review from marcinpurtak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rafalz13 @trymzet