Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ Change sap_credentials variable to credentials #891

Merged
merged 1 commit into from
Apr 10, 2024
Merged

♻️ Change sap_credentials variable to credentials #891

merged 1 commit into from
Apr 10, 2024

Conversation

adrian-wojcik
Copy link
Contributor

@adrian-wojcik adrian-wojcik commented Apr 10, 2024 •
edited
Loading

Summary

Changing back name of the variable sap_credentials to credentials

Importance

Because we do not have to change a lot of flows

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • [X ] adds/updates tests (if appropriate)
  • [ X] adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@adrian-wojcik adrian-wojcik changed the title ♻️ Change sap_credential variable to credentials ♻️ Change sap_credentials variable to credentials Apr 10, 2024
@adrian-wojcik adrian-wojcik requested a review from Rafalz13 April 10, 2024 13:04
@Rafalz13 Rafalz13 merged commit 36cc5ae into dyvenia:dev Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafalz13 Rafalz13 Rafalz13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrian-wojcik @Rafalz13