Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix bug related to logger.warning and tests in sap_rfc source #890

Merged
merged 1 commit into from
Apr 10, 2024
Merged

🐛 Fix bug related to logger.warning and tests in sap_rfc source #890

merged 1 commit into from
Apr 10, 2024

Conversation

adrian-wojcik
Copy link
Contributor

Summary

Fixing bug related to tests after previous changes and changed logger.warning info in source .

Importance

Checklist

This PR:

  • [X ] follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • [ X] adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@adrian-wojcik adrian-wojcik requested a review from Rafalz13 April 10, 2024 08:09
@adrian-wojcik adrian-wojcik changed the title 🐛 Fix mug related to logger.warning and tests in sap_rfc 🐛 Fix bug related to logger.warning and tests in sap_rfc source Apr 10, 2024
Rafalz13
Rafalz13 approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Rafalz13 Rafalz13 merged commit b2d8a76 into dyvenia:dev Apr 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafalz13 Rafalz13 Rafalz13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adrian-wojcik @Rafalz13