Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub action bug #832

Merged
merged 2 commits into from
Dec 19, 2023
Merged

GitHub action bug #832

merged 2 commits into from
Dec 19, 2023

Conversation

burzekj
Copy link
Contributor

@burzekj burzekj commented Dec 12, 2023

Summary

Changed github action only to check if code is formatted with black formatter.

Importance

Fixing the bug related to github action on PR's with incorrected formatted code.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@burzekj burzekj requested a review from k-wolski December 12, 2023 13:12
k-wolski
k-wolski approved these changes Dec 12, 2023
View reviewed changes
Copy link

@k-wolski k-wolski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. If the handling is not helping and causing issues from time to time, it's better to keep this process manuall for now.

@Rafalz13 Rafalz13 merged commit 6b04825 into dyvenia:dev Dec 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@k-wolski k-wolski k-wolski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@burzekj @k-wolski @Rafalz13