Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 0.4.23 PR #828

Merged
merged 68 commits into from
Dec 7, 2023
Merged

Release 0.4.23 PR #828

merged 68 commits into from
Dec 7, 2023

Conversation

Rafalz13
Copy link
Contributor

@Rafalz13 Rafalz13 commented Dec 7, 2023 •
edited
Loading

Summary

Release 0.4.23 PR

Importance

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

Rafalz13 and others added 30 commits November 15, 2023 14:11
@Rafalz13
🚀 Bumped version after release
551203c
@Rafalz13
📝 Added docstring to slugify()
53eae88
@Rafalz13
✅ Added tests for slugify() and handle_api_response()
b056a05
@Rafalz13
✅ Added missing test for check_value()
ef4a650
@Rafalz13
✅ Added SQL related missing tests
78ea413
@Rafalz13
✅ Added missing test for gen_bulk_insert_query_from_df
91ea25c
@Rafalz13
✅ Added missing test for union_dict()
bcdfa98
@burzec-dyv
✨ Added new logic to map and reorder output df
74beb6e
@burzec-dyv
Added CHANGELOG.md
2885731
@KaterynaIurieva
Updated api url in connector
e6c82e3
@KaterynaIurieva
Updated api url in connector
a638571
@KaterynaIurieva
Merge branch 'fix_vidclub_connector' of https://github.com/KaterynaIu…
6bb29fe 
…rieva/viadot into fix_vidclub_connector
@KaterynaIurieva @adrian-wojcik
Update viadot/sources/vid_club.py
5092684 
Co-authored-by: Adrian Wójcik <[email protected]>
@KaterynaIurieva @adrian-wojcik
Update viadot/sources/vid_club.py
45250ea 
Co-authored-by: Adrian Wójcik <[email protected]>
@marcinpurtak
function to check if df empty
19b9812
@marcinpurtak
function to check if df empty enhanced
c4f07df
@cgildenia
♻️ merged path and adls_file_name into file_name
df729f5
@cgildenia
♻️ updated docstring
759adf2
@cgildenia
✨ added to_csv in list class
495f3c5
@burzec-dyv
✅ added more tests for genesys Task
8a61518
@marcinpurtak
Modified logic for check df. Df check and flow Finish in the flow added
34859ed
@cgildenia
♻️ removed unused code
b10a951
@cgildenia
✨ added separator argument for csv saving
6dc7a6f
@Rafalz13
⚡️ Replaced check_value and get_nested_dict with one - `get_neste…
7c6b9e3 
…d_value`
@Rafalz13
🐛 Added tests for test_nested_value function
102fc93
@Rafalz13
♻️ Changed funtion from get_nested_dict to get_nested_value
8956716
@Rafalz13
♻️ Changed funtion from check_value to get_nested_value in genesys
dfacdfa
@burzec-dyv
Changed dosc string for new class arguments
416ca6e
@Rafalz13
Merge pull request #820 from burzekj/web_msg_logic_fix
895b1d0 
Web msg logic fix
@marcinpurtak
update for sharepoint list to df with function for checking df
b6cfd41
KaterynaIurieva and others added 27 commits December 5, 2023 12:06
@KaterynaIurieva
Merge branch 'fix_vidclub_connector' of https://github.com/KaterynaIu…
35f9840 
…rieva/viadot into fix_vidclub_connector
@marcinpurtak
changed raise to endrun
635c146
@Rafalz13
Merge pull request #823 from cgildenia/sharepoint_list_to_csv
1e57011 
Sharepoint list to csv
@KaterynaIurieva
unify region parameter
48ddcd6
@Rafalz13
Merge pull request #825 from gwieloch/sapbw
8bea0c6 
added conn.close after each session to sappw
@marcinpurtak
Moved tasks to task_utils + tests added
be1a72e
@Rafalz13
Merge branch 'dev' into sap_rfc_credential_error_bug
bcefcc7
@marcinpurtak
Merge branch 'dev' of https://github.com/dyvenia/viadot into feature/…
f282f55 
…sharepoint_multiflows_control
@Rafalz13
Merge pull request #824 from adrian-wojcik/sap_rfc_credential_error_bug
6dc722f 
🐛 Added warning logger for credential
@github-actions
🎨 Format Python code with Black
2f7ed2a
@KaterynaIurieva
Fixed total_load method, updated tests
7aac8b0
@Rafalz13
Merge pull request #822 from KaterynaIurieva/fix_vidclub_connector
f7de232 
Fix url in vidclub connector
@angelika233
🔊 Updated logger warning
8f447aa
@marcinpurtak
Updated tests, removed not necessary imports, changed file path param…
8f6075b 
…eter
@Rafalz13
Merge branch 'dev' into feature/sharepoint_multiflows_control
06c3f41
@marcinpurtak @Rafalz13
Apply suggestions from code review
8d326ea 
Added literals for if_no_data_returned and missing dots

Co-authored-by: Rafał Ziemianek <[email protected]>
@marcinpurtak @Rafalz13
Dot added
b63d16e 
Co-authored-by: Rafał Ziemianek <[email protected]>
@marcinpurtak
Formatting fix
9fd6e6f
@Rafalz13
Merge pull request #826 from dyvenia/feature/sharepoint_multiflows_co…
d4589a5 
…ntrol

Feature/sharepoint multiflows control
@Rafalz13
Merge branch 'dev' into improve_utils_coverage
ac1ebcb
@Rafalz13
Merge pull request #817 from dyvenia/improve_utils_coverage
f269f3e 
Improve `utils.py` test coverage
@Rafalz13
🐛 Changed cols_to_drop in VidClub
bd0d155
@Rafalz13
🐛 Changed test for VidClub flow
41204af
@Rafalz13
🔥 Removed unused parameters
434fc66
@Rafalz13
Merge pull request #827 from dyvenia/fix_tests_for_release4_23
d8b693d 
Fix tests before release
@Rafalz13
🔥 Removed test for get_sql_server_table_dtypes
a9b6f66
@Rafalz13
📝 Updated Changelog before release
a104422
@Rafalz13 Rafalz13 requested a review from m-paz December 7, 2023 11:36
@Rafalz13 Rafalz13 merged commit b4e3156 into main Dec 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m-paz m-paz m-paz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@Rafalz13 @m-paz @burzec-dyv @KaterynaIurieva @marcinpurtak @cgildenia @gwieloch @angelika233