Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tests before release #827

Merged
merged 3 commits into from
Dec 7, 2023
Merged

Fix tests before release #827

merged 3 commits into from
Dec 7, 2023

Conversation

Rafalz13
Copy link
Contributor

@Rafalz13 Rafalz13 commented Dec 7, 2023 •
edited
Loading

Summary

Fix failed tests before release

Importance

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@Rafalz13 Rafalz13 requested review from m-paz and angelika233 December 7, 2023 10:15
angelika233
angelika233 approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@angelika233 angelika233 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@Rafalz13 Rafalz13 merged commit d8b693d into dev Dec 7, 2023
2 of 3 checks passed
@trymzet trymzet deleted the fix_tests_for_release4_23 branch March 19, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@angelika233 angelika233 angelika233 approved these changes

@m-paz m-paz m-paz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Rafalz13 @m-paz @angelika233