-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/sharepoint list extension kpi5 #810
Merged
Rafalz13
merged 9 commits into
dyvenia:dev
from
marcinpurtak:feature/sharepoint_list_extension_KPI5
Nov 15, 2023
Merged
Feature/sharepoint list extension kpi5 #810
Rafalz13
merged 9 commits into
dyvenia:dev
from
marcinpurtak:feature/sharepoint_list_extension_KPI5
Nov 15, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcinpurtak
force-pushed
the
feature/sharepoint_list_extension_KPI5
branch
from
November 14, 2023 14:26
3471b98
to
8850d83
Compare
…small fixes and docstring update
marcinpurtak
force-pushed
the
feature/sharepoint_list_extension_KPI5
branch
from
November 14, 2023 14:28
8850d83
to
3991b5f
Compare
burzekj
suggested changes
Nov 14, 2023
burzekj
approved these changes
Nov 14, 2023
Rafalz13
requested changes
Nov 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added few comments. Please add missing docstrings.
…ub.com/marcinpurtak/viadot into feature/sharepoint_list_extension_KPI5
marcinpurtak
force-pushed
the
feature/sharepoint_list_extension_KPI5
branch
from
November 15, 2023 08:46
27be1ed
to
49512f9
Compare
Rafalz13
reviewed
Nov 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Only 1 change.
Rafalz13
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Source, task and flow for sharepoint list connector updated to handle new types of fields and special characters
Small code improvements
Docstring and parameters update
Importance
Import for extraction of new fields
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md