Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/sharepoint list extension kpi5 #810

Merged

Conversation

marcinpurtak
Copy link
Collaborator

Summary

Source, task and flow for sharepoint list connector updated to handle new types of fields and special characters
Small code improvements
Docstring and parameters update

Importance

Import for extraction of new fields

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@marcinpurtak marcinpurtak force-pushed the feature/sharepoint_list_extension_KPI5 branch from 3471b98 to 8850d83 Compare November 14, 2023 14:26
@marcinpurtak marcinpurtak force-pushed the feature/sharepoint_list_extension_KPI5 branch from 8850d83 to 3991b5f Compare November 14, 2023 14:28
viadot/tasks/sharepoint.py Outdated Show resolved Hide resolved
@marcinpurtak marcinpurtak requested a review from burzekj November 14, 2023 14:39
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added few comments. Please add missing docstrings.

CHANGELOG.md Show resolved Hide resolved
viadot/flows/sharepoint_to_adls.py Outdated Show resolved Hide resolved
viadot/flows/sharepoint_to_adls.py Outdated Show resolved Hide resolved
viadot/flows/sharepoint_to_adls.py Outdated Show resolved Hide resolved
viadot/sources/sharepoint.py Outdated Show resolved Hide resolved
viadot/tasks/sharepoint.py Outdated Show resolved Hide resolved
viadot/tasks/sharepoint.py Outdated Show resolved Hide resolved
viadot/flows/sharepoint_to_adls.py Outdated Show resolved Hide resolved
viadot/sources/sharepoint.py Outdated Show resolved Hide resolved
viadot/sources/sharepoint.py Outdated Show resolved Hide resolved
@marcinpurtak marcinpurtak force-pushed the feature/sharepoint_list_extension_KPI5 branch from 27be1ed to 49512f9 Compare November 15, 2023 08:46
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Only 1 change.

CHANGELOG.md Outdated Show resolved Hide resolved
@Rafalz13 Rafalz13 merged commit 3389cb1 into dyvenia:dev Nov 15, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants