Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add hardcoded dtypes length check #759

Closed
wants to merge 3 commits into from
Closed

✨ Add hardcoded dtypes length check #759

wants to merge 3 commits into from

Conversation

malgorzatagwinner
Copy link
Contributor

Summary

✨ Add hardcoded dtypes length check to avoid downloading bigger data than the dtypes allow

Importance

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

Rafalz13
Rafalz13 requested changes Oct 5, 2023
View reviewed changes
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Added some comments please check and update docstrings
  • Please add tests for new functions

viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Outdated Show resolved Hide resolved
Rafalz13
Rafalz13 reviewed Oct 9, 2023
View reviewed changes
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added some comments.

viadot/flows/adls_to_azure_sql.py Show resolved Hide resolved
viadot/flows/adls_to_azure_sql.py Show resolved Hide resolved
tests/integration/flows/test_adls_to_azure_sql.py Outdated Show resolved Hide resolved
tests/integration/flows/test_adls_to_azure_sql.py Outdated Show resolved Hide resolved
@Rafalz13 Rafalz13 deleted the branch dyvenia:dev April 11, 2024 08:24
@Rafalz13 Rafalz13 closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rafalz13 Rafalz13 Rafalz13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@malgorzatagwinner @Rafalz13