Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

♻️ Changed _and_add_viadot_metadata_columns_decorator and aplied it t… #758

Merged
merged 4 commits into from
Oct 10, 2023
Merged

♻️ Changed _and_add_viadot_metadata_columns_decorator and aplied it t… #758

merged 4 commits into from
Oct 10, 2023

Conversation

adrian-wojcik
Copy link
Contributor

…o sharepoint task

Summary

Refactoring _add_viadot_metadata_columns_decorator in order to able implementation to sources where function 'to_df' is located in task instead of source. Moreover this decorator is applied to SharePoint task.

Importance

Because it is adding ability to use _add_viadot_metadata_columns_decorator also in sources where function to_df is in task file.

Checklist

This PR:

  • follows the guidelines laid out in CONTRIBUTING.md
  • links relevant issue(s)
  • adds/updates tests (if appropriate)
  • adds/updates docstrings (if appropriate)
  • adds an entry in CHANGELOG.md

@adrian-wojcik adrian-wojcik requested a review from Rafalz13 October 5, 2023 06:32
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments.

viadot/utils.py Outdated Show resolved Hide resolved
viadot/utils.py Outdated Show resolved Hide resolved
viadot/utils.py Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@adrian-wojcik adrian-wojcik requested a review from Rafalz13 October 5, 2023 07:21
Copy link
Contributor

@Rafalz13 Rafalz13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good.

CHANGELOG.md Outdated Show resolved Hide resolved
@Rafalz13 Rafalz13 merged commit 35ecc6a into dyvenia:dev Oct 10, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants