-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [BUGFIX] For SAPRFCV2
adding whitespaces to match sub - queries
#1100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hi @trymzet Thanks! |
trymzet
requested changes
Nov 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added feedback, can you pls also add at least 1 unit test for this?
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
Co-authored-by: Michał Zawadzki <[email protected]>
trymzet
approved these changes
Nov 21, 2024
m-paz
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Seems like SAP returns columns with different amount of whitespaces - ideally SAP server should always add whitespaces , that the amount of characters matches the declared data type in SAP table definition.
However, after some investigation , looks like from every n-th SAP request, it is trimming all whitespaces or messing the number of added ones - which could lead to wrongly merged SAP responses using unique columns as the merge key.
In this PR there is a solution, that, for each UNIQUE columns, checks the returned SAP table metadata to obtain what is the declared data type ( and the characters amount ) , then it checks what is the received character amount and adds whitespaces to match the declared one.
Whitespaces are added using vector/matrix approach which doesn't slow down the ingestion process ( not a huge impact on performance).
This PR closes #556
Importance
Important because missing whitespaces could lead to problems with joining sub - queries based on the unique columns
Checklist
This PR:
CONTRIBUTING.md
CHANGELOG.md