♻️ Change logic of checking credentials_keys dictionary from task to …

…the source level

viadot/sources/sap_rfc.py

@@ -266,6 +266,16 @@ def __init__(
         self.sap_credentials_key = sap_credentials_key
         self.env = env
 
+        if isinstance(sap_credentials, dict):
+            credentials_keys = list(sap_credentials.keys())
+            required_credentials_params = ["sysnr", "user", "passwd", "ashost"]
+            for key in required_credentials_params:
+                if key not in credentials_keys:
+                    self.logger.warning(
+                        f"Required key '{key}' not found in your 'sap_credentials' dictionary!"
+                    )
+                    sap_credentials = None
+
         if sap_credentials is None:
             logger.warning(
                 f"Your credentials will use {env} environment from local config. If you would like to use different one - please specified it in sap_credentials parameter."
@@ -718,6 +728,16 @@ def __init__(
         self.sap_credentials_key = sap_credentials_key
         self.env = env
 
+        if isinstance(sap_credentials, dict):
+            credentials_keys = list(sap_credentials.keys())
+            required_credentials_params = ["sysnr", "user", "passwd", "ashost"]
+            for key in required_credentials_params:
+                if key not in credentials_keys:
+                    self.logger.warning(
+                        f"Required key '{key}' not found in your 'sap_credentials' dictionary!"
+                    )
+                    sap_credentials = None
+
         if sap_credentials is None:
             logger.warning(
                 f"Your credentials will use {env} environment from local config. If you would like to use different one - please specified it in sap_credentials parameter."

viadot/tasks/sap_rfc.py

@@ -133,16 +133,6 @@ def run(
             pd.DataFrame: DataFrame with SAP data.
         """
 
-        if isinstance(sap_credentials, dict):
-            credentials_keys = list(sap_credentials.keys())
-            required_credentials_params = ["sysnr", "user", "passwd", "ashost"]
-            for key in required_credentials_params:
-                if key not in credentials_keys:
-                    self.logger.warning(
-                        f"Required key '{key}' not found in your 'sap_credentials' dictionary!"
-                    )
-                    sap_credentials = None
-
         if sap_credentials is None:
             credentials_str = AzureKeyVaultSecret(
                 secret=sap_credentials_key,