✅ Changed parameter names in sharepoint tests

dyvenia · Jun 19, 2024 · af4cf86 · af4cf86
1 parent ab10bb7
commit af4cf86
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/tests/unit/test_sharepoint.py b/tests/unit/test_sharepoint.py
@@ -11,21 +11,21 @@ def _download_excel(self, url=None):
 
 def test_sharepoint_default_na():
     dummy_creds = {"site": "test", "username": "test2", "password": "test"}
-    na_values1 = Sharepoint.DEFAULT_NA_VALUES
 
     s = SharepointMock(credentials=dummy_creds)
-    df = s.to_df(url="test", na_values=na_values1)
+    df = s.to_df(url="test", na_values=Sharepoint.DEFAULT_NA_VALUES)
 
     assert not df.empty
     assert "NA" not in list(df["col_a"])
 
 
 def test_sharepoint_custom_na():
     dummy_creds = {"site": "test", "username": "test", "password": "test"}
-    na_values2 = Sharepoint.DEFAULT_NA_VALUES
 
     s = SharepointMock(credentials=dummy_creds)
-    df = s.to_df(url="test", na_values=na_values2.remove("NA"))
+    df = s.to_df(
+        url="test", na_values=[v for v in Sharepoint.DEFAULT_NA_VALUES if v != "NA"]
+    )
 
     assert not df.empty
     assert "NA" in list(df["col_a"])