♻️ Refactor saprfc task in order to meet new logic in source

dyvenia · Mar 15, 2024 · 2d3ee8d · 2d3ee8d
1 parent 92c2b70
commit 2d3ee8d
Showing 1 changed file with 11 additions and 6 deletions.
diff --git a/viadot/tasks/sap_rfc.py b/viadot/tasks/sap_rfc.py
@@ -19,7 +19,7 @@
 class SAPRFCToDF(Task):
     def __init__(
         self,
-        query: str,
+        query: str = None,
         sep: str = None,
         replacement: str = "-",
         func: str = None,
@@ -87,7 +87,7 @@ def __init__(
         "replacement",
         "func",
         "rfc_total_col_width_character_limit",
-        "credentials",
+        "sap_credentials",
     )
     def run(
         self,
@@ -134,10 +134,15 @@ def run(
         """
 
         if sap_credentials is None:
-            credentials_str = AzureKeyVaultSecret(
-                secret=sap_credentials_key,
-            ).run()
-            sap_credentials = json.loads(credentials_str).get(env)
+            try:
+                credentials_str = AzureKeyVaultSecret(
+                    secret=sap_credentials_key,
+                ).run()
+                sap_credentials = json.loads(credentials_str).get(env)
+            except:
+                logger.warning(
+                    f"Getting credentials from Azure Key Vault was not possible. Either there is no key: {sap_credentials_key} or env: {env} or there is not Key Vault in your environment."
+                )
 
         if alternative_version is True:
             if rfc_unique_id: