Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: update development.md, maintainers.md and security.md #844

Merged
merged 4 commits into from
Oct 9, 2023
Merged

doc: update development.md, maintainers.md and security.md #844

merged 4 commits into from
Oct 9, 2023

Conversation

pedaars
Copy link
Contributor

@pedaars pedaars commented Oct 7, 2023

Development.md

  • change the path to the AGENT_PROTO_COMPATIBILITY_MINIMUM_VERSION and added a link to the const.ts file.
  • add white space to improve readability

Maintainers.md

  • update grammar to improve readability

Security.md

  • add links to dyrector.io
  • add mailto links to email address

@pedaars pedaars requested a review from a team as a code owner October 7, 2023 09:30
polaroi8d
polaroi8d requested changes Oct 9, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please adhere to the CONTRIBUTING.md guidelines for the PR title. Otherwise, great job! Thank you!

@pedaars pedaars changed the title #827 - Update development.md, maintainers.md and security.md doc/Update development.md, maintainers.md and security.md Oct 9, 2023
@pedaars pedaars changed the title doc/Update development.md, maintainers.md and security.md doc: update development.md, maintainers.md and security.md Oct 9, 2023
polaroi8d
polaroi8d requested changes Oct 9, 2023
View reviewed changes
DEVELOPMENT.md Show resolved Hide resolved
@polaroi8d polaroi8d added source:documentation Improvements or additions to documentation pr:doc severity:medium labels Oct 9, 2023
@gerimate
Copy link
Contributor

gerimate commented Oct 9, 2023

LGTM, good job!

@polaroi8d polaroi8d merged commit f8352e1 into dyrector-io:develop Oct 9, 2023
26 checks passed
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
@pedaars @chandhuDev
doc: update development.md, maintainers.md and security.md (dyrector-…
24fc072 
…io#844)

* dyrector-io#827 - Update development.md, maintainers.md and security.md

* Update DEVELOPMENT.md

* Update DEVELOPMENT.md

---------

Co-authored-by: Levente Orban <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerimate gerimate gerimate approved these changes

@polaroi8d polaroi8d polaroi8d approved these changes

@robot9706 robot9706 robot9706 approved these changes

Assignees

@pedaars pedaars

Labels
pr:doc severity:medium source:documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pedaars @gerimate @robot9706 @polaroi8d