Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cicd: add more coverage files, to display a more valid number #840

Merged
merged 6 commits into from
Oct 9, 2023
Merged

cicd: add more coverage files, to display a more valid number #840

merged 6 commits into from
Oct 9, 2023

Conversation

nandor-magyar
Copy link
Contributor

We have not sent all the golang test results to codecov, addressing this in this PR.

@nandor-magyar nandor-magyar requested a review from a team as a code owner October 5, 2023 08:42
@nandor-magyar nandor-magyar changed the title ci: add more coverage files, to display a more valid number ci(golang: add more coverage files, to display a more valid number Oct 5, 2023
@nandor-magyar nandor-magyar changed the title ci(golang: add more coverage files, to display a more valid number ci(golang): add more coverage files, to display a more valid number Oct 5, 2023
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:golang labels Oct 5, 2023
@github-actions github-actions bot added lang:typescript lang:makefile source:ci Workflow files source:build Makefiles, Dockerfiles, etc labels Oct 5, 2023
@nandor-magyar nandor-magyar changed the title ci(golang): add more coverage files, to display a more valid number cicd(golang): add more coverage files, to display a more valid number Oct 5, 2023
@nandor-magyar nandor-magyar changed the title cicd(golang): add more coverage files, to display a more valid number cicd: add more coverage files, to display a more valid number Oct 5, 2023
@nandor-magyar nandor-magyar force-pushed the fix/send-actual-squashed-coverage branch from 5cb36b6 to 8475b79 Compare October 5, 2023 09:07
@github-actions github-actions bot added pr:ci and removed source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:golang lang:typescript labels Oct 5, 2023
@nandor-magyar nandor-magyar force-pushed the fix/send-actual-squashed-coverage branch from 8475b79 to 04c7e5b Compare October 5, 2023 09:11
@polaroi8d
Copy link
Collaborator

Why is this branch showing the same percentage?

@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. lang:golang labels Oct 5, 2023
@nandor-magyar
Copy link
Contributor Author

@polaroi8d the readme contains a link to an image of the develop branch.

@polaroi8d
Copy link
Collaborator

@polaroi8d the readme contains a link to an image of the develop branch.

Ahh okey.

@nandor-magyar nandor-magyar force-pushed the fix/send-actual-squashed-coverage branch 3 times, most recently from 964463c to 558bfc0 Compare October 6, 2023 11:26
@nandor-magyar nandor-magyar force-pushed the fix/send-actual-squashed-coverage branch 2 times, most recently from 11b28f7 to 238af26 Compare October 6, 2023 12:38
@codecov
Copy link

codecov bot commented Oct 6, 2023 •
edited
Loading

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (c7d2a60) 24.29% compared to head (34517b0) 26.42%.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #840      +/-   ##
===========================================
+ Coverage    24.29%   26.42%   +2.13%     
===========================================
  Files           62       69       +7     
  Lines         5994     7288    +1294     
===========================================
+ Hits          1456     1926     +470     
- Misses        4432     5211     +779     
- Partials       106      151      +45
Files Coverage Δ
golang/pkg/crane/k8s/deployment.go 14.90% <0.00%> (+3.67%) ⬆️
golang/pkg/crane/k8s/deploy_facade.go 0.00% <0.00%> (ø)

... and 19 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nandor-magyar nandor-magyar force-pushed the fix/send-actual-squashed-coverage branch from 238af26 to 34517b0 Compare October 6, 2023 14:05
@nandor-magyar nandor-magyar merged commit 95ba6c6 into develop Oct 9, 2023
27 of 28 checks passed
@nandor-magyar nandor-magyar deleted the fix/send-actual-squashed-coverage branch October 9, 2023 07:55
chandhuDev pushed a commit to chandhuDev/dyrectorio that referenced this pull request Nov 7, 2023
@nandor-magyar @chandhuDev
cicd: add more coverage files, to display a more valid number (dyrect…
ad9461e 
…or-io#840)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

Assignees

@nandor-magyar nandor-magyar

Labels
lang:golang lang:makefile pr:ci pr:cicd source:agent The scope of the issue or pull request is agent. source:build Makefiles, Dockerfiles, etc source:ci Workflow files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nandor-magyar @polaroi8d