Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: configurations #1018

Merged
merged 45 commits into from
Jan 6, 2025
Merged

refactor: configurations #1018

merged 45 commits into from
Jan 6, 2025

Conversation

m8vago
Copy link
Contributor

@m8vago m8vago commented Nov 25, 2024

  • Add deployment configuration
  • Add config bundle configuration
  • Unify configuration pages under /container-configurations/:id

@m8vago m8vago requested a review from a team as a code owner November 25, 2024 14:03
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:golang lang:typescript lang:sql source:proto Protobuf related changes. and removed pr:refactor labels Nov 25, 2024
@m8vago m8vago marked this pull request as draft November 25, 2024 14:04
@m8vago m8vago force-pushed the refactor/configurations branch 6 times, most recently from e019ed1 to a49ced4 Compare November 26, 2024 08:56
@m8vago m8vago force-pushed the refactor/configurations branch 3 times, most recently from 4de6804 to e4cc576 Compare November 26, 2024 10:04
@m8vago m8vago force-pushed the refactor/configurations branch from e4cc576 to 2a6dc53 Compare November 26, 2024 14:32
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 138 lines in your changes missing coverage. Please review.

Project coverage is 24.09%. Comparing base (c592368) to head (ad74ce8).
Report is 12 commits behind head on develop.

Files with missing lines Patch % Lines
golang/internal/grpc/grpc.go 0.00% 40 Missing ⚠️
golang/pkg/dagent/utils/docker.go 0.00% 34 Missing ⚠️
golang/pkg/dagent/utils/prefix_file.go 55.55% 22 Missing and 6 partials ⚠️
golang/internal/mapper/grpc.go 50.00% 11 Missing ⚠️
golang/pkg/crane/k8s/deploy_facade.go 0.00% 11 Missing ⚠️
golang/pkg/crane/k8s/delete_facade.go 0.00% 9 Missing ⚠️
golang/pkg/crane/crux/deploy.go 0.00% 3 Missing ⚠️
golang/pkg/crane/crane.go 0.00% 1 Missing ⚠️
golang/pkg/dagent/dagent.go 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1018      +/-   ##
===========================================
- Coverage    24.34%   24.09%   -0.26%     
===========================================
  Files           77       77              
  Lines         8104     8164      +60     
===========================================
- Hits          1973     1967       -6     
- Misses        5972     6038      +66     
  Partials       159      159              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@m8vago m8vago force-pushed the refactor/configurations branch from 4d55566 to 65a8cc1 Compare December 3, 2024 15:24
@m8vago m8vago force-pushed the refactor/configurations branch from 65a8cc1 to 038495d Compare December 3, 2024 15:25
@robot9706 robot9706 mentioned this pull request Dec 4, 2024
@m8vago m8vago force-pushed the refactor/configurations branch from d376b2e to c8dd2ca Compare December 6, 2024 11:19
@m8vago m8vago force-pushed the refactor/configurations branch from 04a268f to d07b617 Compare December 6, 2024 14:26
@m8vago m8vago force-pushed the refactor/configurations branch from 2bc093b to 7ef8f77 Compare January 6, 2025 12:40
@m8vago m8vago merged commit 50c0759 into develop Jan 6, 2025
26 checks passed
@m8vago m8vago deleted the refactor/configurations branch January 6, 2025 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang:golang lang:sql lang:typescript pr:refactor source:agent The scope of the issue or pull request is agent. source:proto Protobuf related changes. source:web The scope of the issue or pull request is web.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants