Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REFACTOR - ShowDirections field to AddressDataExtension #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

REFACTOR - ShowDirections field to AddressDataExtension #13

wants to merge 1 commit into from

Conversation

jsirish
Copy link
Member

@jsirish jsirish commented Oct 1, 2017

No description provided.

@jsirish
Copy link
Member Author

jsirish commented Oct 1, 2017

Not sure if this belongs in geocoder, or another repo? Was in core-tools.

@jsirish jsirish requested a review from muskie9 October 1, 2017 18:43
@codecov
Copy link

codecov bot commented Oct 1, 2017 •
edited
Loading

Codecov Report

Merging #13 into master will increase coverage by 5.11%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #13      +/-   ##
============================================
+ Coverage     22.35%   27.47%   +5.11%     
  Complexity       27       27              
============================================
  Files             4        4              
  Lines            85       91       +6     
============================================
+ Hits             19       25       +6     
  Misses           66       66
Impacted Files Coverage Δ Complexity Δ
src/AddressDataExtension.php 54.34% <100%> (+6.84%) 13 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6870aae...638526b. Read the comment docs.

@muskie9
Copy link
Member

muskie9 commented Feb 13, 2018

I think this still makes sense... might be able to bring in #17 as well.

muskie9
muskie9 approved these changes Oct 6, 2020
View reviewed changes
Copy link
Member

@muskie9 muskie9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good if this is still valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@muskie9 muskie9 muskie9 approved these changes

Assignees
No one assigned
Labels
question
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsirish @muskie9