Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(MultipleVote): create a config input for the vote limit #67

Merged
merged 8 commits into from
Mar 13, 2024

Conversation

dyaskur
Copy link
Owner

@dyaskur dyaskur commented Mar 12, 2024

Include the feature outlined in #8 as well as the one requested in #57.

As the chat message remains static, determining the current active user is not feasible. To enable multiple votes, we'll utilize a dialog system.

@coveralls
Copy link

coveralls commented Mar 12, 2024

Pull Request Test Coverage Report for Build 8257842593

Details

  • 72 of 73 (98.63%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 93.873%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/handlers/ActionHandler.ts 19 20 95.0%
Totals Coverage Status
Change from base Build 8232733705: -0.3%
Covered Lines: 550
Relevant Lines: 568

💛 - Coveralls

@dyaskur dyaskur self-assigned this Mar 12, 2024
@dyaskur dyaskur force-pushed the feat/multiple_vote branch from 7368987 to e43340e Compare March 13, 2024 00:48
Copy link

sonarcloud bot commented Mar 13, 2024

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@dyaskur
Copy link
Owner Author

dyaskur commented Mar 13, 2024

Here is the screenshot of the config dialog:

CleanShot 2024-03-13 at 08 10 44@2x

And here is the voting dialog:
CleanShot 2024-03-13 at 08 10 02@2x

@dyaskur dyaskur merged commit d227132 into master Mar 13, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants