-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR: Get and Cache List of Roles + Helper Functions: has_role?/2 #7
Conversation
Codecov Report
@@ Coverage Diff @@
## master #7 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 1 1
Lines 4 38 +34
=========================================
+ Hits 4 38 +34
Continue to review full report at Codecov.
|
@th0mas this PR is in a reviewable state. 🔍 🙏 |
@nelsonic can you give me write access to this branch so I can push some of my refactoring commits? |
@th0mas please confirm you have write access. Thanks. 🔑 |
@nelsonic got it cheers |
@th0mas I have made a few updates addressing all your PR review comments.
You can call Please take another look at the PR when you're back at your desk tomorrow. 🙏 Note: LMK your thoughts. 👍 |
Looks good 👍 |
This Pull Request adds:
RBAC.has_role?/2
(String
) andRBAC.has_role_any?/2
(List
)