Search store #9

RobStallion · 2019-03-11T14:31:33Z

#8 #1

Caches the dummy data being used as store info in ets on application start up
Allows user to enter a postcode and distance to search within to filter stores.
Validates postcode with postcodes.io

…nd as lowercase #8

…ache on app start up #8

…ain distance #8

…lid. Refactor code #8

nelsonic · 2019-03-11T15:39:30Z

lib/store_finder/haversine.ex

@@ -18,4 +8,14 @@ defmodule StoreFinder.Haversine do
        else: acc
    end, [], :store_cache)
  end
+
+  defp calc_distance({lat1, long1}, {lat2, long2}) do
+    v = :math.pi / 180


please consider expanding the variable names for clarity (or adding in-line comments).

nelsonic

@RobStallion nice work! 👍

RobStallion added 9 commits March 11, 2019 11:56

removes default page setup #8

569be23

update get_random_postcodes so it returns a postcode without spaces a…

6f755e4

…nd as lowercase #8

creates a store cache genserver module to handle creating the store c…

49adcaa

…ache on app start up #8

make function private

37cd3d1

create a nearby-stores route which displaces all stores within a cert…

1014062

…ain distance #8

adds regex to check is postcode is valid format #8

725f501

use the users postcode input to search ets cache for nearby stores #8

b8954d6

adds HTTPoison to project to use over httpc for better understanding #8

ea51755

update action to account for cases where postcode looks but is not va…

640afc2

…lid. Refactor code #8

RobStallion assigned nelsonic Mar 11, 2019

RobStallion requested a review from nelsonic March 11, 2019 14:32

RobStallion added the awaiting-review label Mar 11, 2019

nelsonic added in-review and removed awaiting-review labels Mar 11, 2019

nelsonic reviewed Mar 11, 2019

View reviewed changes

nelsonic approved these changes Mar 11, 2019

View reviewed changes

nelsonic merged commit 5ddaf6c into master Mar 11, 2019

nelsonic deleted the search-store branch March 11, 2019 15:41

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Search store #9

Search store #9

RobStallion commented Mar 11, 2019

nelsonic Mar 11, 2019

nelsonic left a comment

Search store #9

Search store #9

Conversation

RobStallion commented Mar 11, 2019

nelsonic Mar 11, 2019

Choose a reason for hiding this comment

nelsonic left a comment

Choose a reason for hiding this comment