Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Fixing build #22

Merged
merged 1 commit into from
Oct 27, 2022
Merged

[PR] Fixing build #22

merged 1 commit into from
Oct 27, 2022

Conversation

LuchoTurtle
Copy link
Member

@LuchoTurtle LuchoTurtle commented Oct 26, 2022

fixes #23

As I was reading the MVP readme refactor issue, I took a gander at this repo and decided to push this simple PR to fix the building issue when cloning the repository.

According to the Elixir Forum this error is because LiveView modules were reorganized on >= 0.18.

@LuchoTurtle LuchoTurtle added the chore a tedious but necessary task often paying technical debt label Oct 26, 2022
@LuchoTurtle LuchoTurtle requested a review from nelsonic October 26, 2022 11:21
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #22 (5356adb) into main (2ae082c) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main       #22   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines           52        62   +10     
=========================================
+ Hits            52        62   +10     
Impacted Files Coverage Δ
lib/stopwatch_web/live/stopwatch_live.ex 100.00% <0.00%> (ø)
lib/stopwatch_web/live/stopwatch_live_js.ex 100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@LuchoTurtle LuchoTurtle mentioned this pull request Oct 26, 2022
7 tasks
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much for opening the issue to report this and fixing it! 🎉

@nelsonic nelsonic merged commit 46173ec into main Oct 27, 2022
@nelsonic nelsonic deleted the build-fix branch October 27, 2022 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore a tedious but necessary task often paying technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

undefined function live_flash/2 error when cloning this repo
2 participants