Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Bandit instead of Cowboy #217

Merged
merged 3 commits into from
Oct 3, 2024
Merged

Update to Bandit instead of Cowboy #217

merged 3 commits into from
Oct 3, 2024

Conversation

ndrean
Copy link
Contributor

@ndrean ndrean commented Oct 3, 2024

I also added the missing "logo.svg" as the folder "priv/static/" was in ".gitignore". The error is therefor removed. #185

This should close #216

nelsonic
nelsonic previously approved these changes Oct 3, 2024
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndrean excellent update as always. ❤️ 🙏
Could you please just update the version of Elixir in the GitHub Actions CI so it doesn't fail?
https://github.com/dwyl/phoenix-liveview-counter-tutorial/actions/runs/11164278975/job/31033222438
image

@nelsonic
Copy link
Member

nelsonic commented Oct 3, 2024

This line needs to be updated:

elixir-version: '1.14.2' # Define the elixir version [required]

@ndrean
Copy link
Contributor Author

ndrean commented Oct 3, 2024

I will also close #214 by adding commented classes !!!???!!! Works...

@ndrean
Copy link
Contributor Author

ndrean commented Oct 3, 2024

#213 should also be closed with this I believe. And #211 and #185.

@ndrean
Copy link
Contributor Author

ndrean commented Oct 3, 2024

Also to update the resumé:

beginners tutorial building a real time counter in 

> Phoenix 1.7.7 + LiveView 0.19

⚡️ 
Phoenix 1.7.14 + LiveView 1.0

Learn the fundamentals from first principals so you can make something amazing!

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice @ndrean ❤️

@nelsonic nelsonic merged commit 9e17460 into dwyl:main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why present increase when refresh the page?
2 participants