Format logout #51
Format logout #51
Conversation
SimonLab
added
the
awaiting-review
| @@ -12,25 +12,24 @@ defmodule AppWeb.PageController do | |||
| def index(conn, _params) do | |||
| url_oauth_google = ElixirAuthGoogle.generate_oauth_url(conn) | |||
| changeset = Person.changeset_registration(%Person{}, %{}) | |||
| render(conn, "index.html", | |||
| [url_oauth_google: url_oauth_google, changeset: changeset]) | |||
| render(conn, "index.html", url_oauth_google: url_oauth_google, changeset: changeset) | |||
There was a problem hiding this comment.
After running mix format this line is now 88 characters long ...
can we add line_length: 80 to .formatter.exs to avoid super-long-lines?
see: https://medium.com/blackode/code-formatter-the-big-feature-in-elixir-v1-6-0-f6572061a4ba
There was a problem hiding this comment.
Added line_length: 80 👍
nelsonic
added
in-review
| @@ -1,7 +1,8 @@ | |||
| defmodule AppWeb.GoogleAuthController do | |||
| use AppWeb, :controller | |||
|
|
|||
| @elixir_auth_google Application.get_env(:app, :elixir_auth_google) || ElixirAuthGoogle | |||
| @elixir_auth_google Application.get_env(:app, :elixir_auth_google) || | |||
| ElixirAuthGoogle | |||
There was a problem hiding this comment.
I don't understand why mix format is indenting this ElixirAuthGoogle by 24 characters ... 😕
Not that it's a problem, I just want to understand if it's consistent. 💭
| @@ -2,6 +2,8 @@ | |||
| <img class="br-100 fl " width="32px" src="<%= @person.picture %>" /> | |||
| </a> | |||
|
|
|||
| <a class="db tr pointer dwyl-teal" href="<%= Routes.person_path(@conn, :logout) %>">Log out</a> | |||
There was a problem hiding this comment.
Apparently eex templates aren't checked for length by mix format ... 95 characters. 💭
| @invalid_attrs %{email: nil, email_hash: nil, familyName: nil, givenName: nil, key_id: nil, password_hash: nil, username: nil, username_hash: nil} | ||
|
|
||
| @valid_attrs %{ | ||
| email: "[email protected]", |
There was a problem hiding this comment.
This is more vertical scrolling but it's much easier read. 👍
format phoenix/elixir files with
mix formatThis PR might be better to look at after #49