[PR] Adding drag n drop and index-based reordering

[LuchoTurtle]

closes #145

This PR is not-completed. It was a quick attempt to get drag-n-drop working on the mvp by following the work done by @SimonLab and implementing a simple way of sorting the items through an index field within the schema.
Every time an item is dropped to a new index, the indexes of the other items would be updated accordingly.
This is done by updating the index of the items before the item with the new index, as well as the ones after the new index.

This is done by using update_all.

Additionally, this PR tries to implement the changes that @SimonLab made in https://github.com/dwyl/learn-alpine.js/blob/main/drag-and-drop.md (through dwyl/learn-alpine.js#5) but I can't seem to get it to work properly (show the yellow highlight change as I drag an item through the list).

Since the focus is on https://github.com/dwyl/app, it makes sense to tackle #145 there instead of the MVP.

I'm pushing this PR because it might have relevant code to tackle this issue later when we'll eventually implement this strategy on the API, which the Flutter app will connect to.

[codecov]

Codecov Report

Merging #345 (6362525) into main (699e6cc) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #345   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           20        22    +2     
  Lines          524       599   +75     
=========================================
+ Hits           524       599   +75     

Files Changed	Coverage Δ
lib/app_web/controllers/auth_controller.ex	100.00% <ø> (ø)
lib/app/cid.ex	100.00% <100.00%> (ø)
lib/app/item.ex	100.00% <100.00%> (ø)
lib/app/list.ex	100.00% <100.00%> (ø)
lib/app_web/controllers/init_controller.ex	100.00% <100.00%> (ø)
lib/app_web/live/app_live.ex	100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[LuchoTurtle]

This should be reviewable.

[nelsonic]

reading through the PR now and noticed that the stats section of the README.md is blank:
https://github.com/dwyl/mvp/blob/drag-drop_fix%23145/BUILDIT.md#14-adding-a-dashboard-to-track-metrics

🤷‍♂️

[LuchoTurtle]

Probably there was a commit that erased the work I had done because I definitely wrote those sections.
You can see those in https://github.com/dwyl/mvp/blob/faba54760ab0435653434aec7c9f801096fbbd8b/BUILDIT.md, for example.

I'll open a separate issue (#348) and I'll dig through the history for the most updated version and restore that section in a different PR.

[panoramix360]

If you need any QA testing, just let me know!

[nelsonic]

I'm going to remove the list_items schema and code from this PR ref: #413
Then will do the final tasks and this should be QA-able.

[nelsonic]

Documented in: https://dwyl.github.io/book/mvp/16-lists.html and https://dwyl.github.io/book/mvp/18-reordering.html 📝 ✅

[nelsonic]

Going to resolve these merge-conflicts quick:

[nelsonic]

GitHub with all it's AI superpowers still hasn't figured out how to auto-resolve merge conflicts and is reporting them incorrectly:

[nelsonic]

I'm not "happy" with the code. There are quite a few inconsistencies in event and variable names. 😕
Specifically the use of both camel case "dragoverItem" and snake case "move_items" and in the app.js file there are even hyphen even names: "remove-highlight" ... I've opened an issue to tidy this code: #416

But since we've waited way too long for the reordering feature I'm not going to do tidy up now. ⏳
Please feel free to pick this up. 🙏

[nelsonic]

This feature is working. ✅
The migrations are non-destructive and can be rolled-back if needed. 🎢
Let's get @iteles to QA it in prod! 👩‍💻
Ship.

[nelsonic]

Obvs there was an issue: #417
I'm looking at it now.
But clearly nobody else is using the MVP as their "daily driver" Todo List (yet) as nobody has "complained" about it.

[LuchoTurtle]

I actually noticed the issue yesterday but didn't raise any issue because, as you've stated, you had created it already over at #417, so I figured there was no point in duplicating 🤷