Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid person duplicate #33

Merged
merged 6 commits into from
Dec 4, 2019
Merged

Avoid person duplicate #33

merged 6 commits into from
Dec 4, 2019

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Dec 4, 2019 •
edited
Loading

ref: #29
Make sure users are not saved multiple times in the database by checking if the email_hash value already exists

@nelsonic nelsonic temporarily deployed to production-avoid-peson-9amx7xl December 4, 2019 09:56 Inactive
@nelsonic nelsonic changed the title Avoid peson duplicate Avoid person duplicate Dec 4, 2019
@nelsonic nelsonic temporarily deployed to production-avoid-peson-2937elf December 4, 2019 09:59 Inactive
@nelsonic nelsonic temporarily deployed to production-avoid-peson-fiprh3e December 4, 2019 10:48 Inactive
@nelsonic nelsonic temporarily deployed to production-avoid-peson-blflgdb December 4, 2019 11:19 Inactive
nelsonic
nelsonic reviewed Dec 4, 2019
View reviewed changes
lib/app/ctx/person.ex
|> put_email_hash()
end

defp put_email_hash(changeset) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nelsonic nelsonic temporarily deployed to production-avoid-peson-3sdynqu December 4, 2019 12:00 Inactive
@SimonLab SimonLab added the awaiting-review An issue or pull request that needs to be reviewed label Dec 4, 2019
nelsonic
nelsonic approved these changes Dec 4, 2019
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab nice one. 👍

@nelsonic nelsonic merged commit bb81c1a into google-authentication-#247 Dec 4, 2019
@nelsonic nelsonic deleted the avoid-peson-duplicate-#29 branch December 4, 2019 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review An issue or pull request that needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic