Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update tests to use EmailHash field #31

Merged
merged 2 commits into from
Dec 3, 2019
Merged

update tests to use EmailHash field #31

merged 2 commits into from
Dec 3, 2019

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Dec 3, 2019

ref: #29

@nelsonic nelsonic temporarily deployed to production-has-email-2-shjtpq2 December 3, 2019 15:09 Inactive
@nelsonic nelsonic temporarily deployed to production-has-email-2-k7aytwo December 3, 2019 15:17 Inactive
nelsonic
nelsonic reviewed Dec 3, 2019
View reviewed changes
lib/app/ctx/person.ex
# |> IO.inspect(label: "person")
|> cast(attrs, [:username, :email, :givenName, :familyName, :password_hash, :key_id, :locale, :picture])
|> validate_required([:username, :email, :givenName, :familyName, :password_hash, :key_id])
|> put_change(:email_hash, emailHash )
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

nelsonic
nelsonic approved these changes Dec 3, 2019
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab thanks for updating the tests. 👍

@nelsonic nelsonic merged commit 198fc40 into person-session-#252 Dec 3, 2019
@nelsonic nelsonic deleted the has-email-#29 branch December 3, 2019 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic