Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update credo dependency to fix warning #91

Merged
merged 9 commits into from
Oct 5, 2019
Merged

Conversation

theodowling
Copy link
Contributor

Resolve issue #90

I've also updated dependencies and fixed some credo warnings.

@nelsonic
Copy link
Member

nelsonic commented Oct 4, 2019

Travis-CI build appears to fail because app cannot connect to Postgres ...

connection refused - :econnrefused

https://travis-ci.org/dwyl/library/builds/593206304#L428
image

@nelsonic
Copy link
Member

nelsonic commented Oct 4, 2019

image

Going to restart/rerun the build on this PR and see if it passes in light of: #94 (added postgres) ...

@nelsonic
Copy link
Member

nelsonic commented Oct 4, 2019

@theodowling looks like the PR won't pass CI until you either rebase on master or add the lines:

services: # ensure that Travis-CI provisions a DB for our tests
  - postgresql

to the .travis.yml file.

https://travis-ci.org/dwyl/library/builds/593679274#L466
image

Thanks for the PR BTW! 🥇

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #91 into master will decrease coverage by 1.09%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #91     +/-   ##
========================================
- Coverage     100%   98.9%   -1.1%     
========================================
  Files          17      17             
  Lines         270     274      +4     
========================================
+ Hits          270     271      +1     
- Misses          0       3      +3
Impacted Files Coverage Δ
lib/library_web/controllers/login_controller.ex 93.33% <0%> (-6.67%) ⬇️
lib/library_web/views/component_view.ex 98.27% <0%> (-1.73%) ⬇️
lib/library_web/controllers/plugs/set_user.ex 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8dda00a...6b7e7c7. Read the comment docs.

@theodowling
Copy link
Contributor Author

Thanks for the tip @nelsonic - rebasing resolved the travis issue.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@theodowling thanks for updating. 🙌

Even though codecov is unhappy, I'm fine with merging as coverage will be improved in the next PR. 👍

@nelsonic nelsonic merged commit 08a2295 into dwyl:master Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants