-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update credo dependency to fix warning #91
Conversation
Travis-CI build appears to fail because app cannot connect to Postgres ...
|
…e#93 Add PostgreSQL Service to .travis.yml for issue dwyl#93
Going to restart/rerun the build on this PR and see if it passes in light of: #94 (added postgres) ... |
@theodowling looks like the PR won't pass CI until you either rebase on services: # ensure that Travis-CI provisions a DB for our tests
- postgresql to the https://travis-ci.org/dwyl/library/builds/593679274#L466 Thanks for the PR BTW! 🥇 |
Codecov Report
@@ Coverage Diff @@
## master #91 +/- ##
========================================
- Coverage 100% 98.9% -1.1%
========================================
Files 17 17
Lines 270 274 +4
========================================
+ Hits 270 271 +1
- Misses 0 3 +3
Continue to review full report at Codecov.
|
Thanks for the tip @nelsonic - rebasing resolved the travis issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@theodowling thanks for updating. 🙌
Even though codecov is unhappy, I'm fine with merging as coverage will be improved in the next PR. 👍
Resolve issue #90
I've also updated dependencies and fixed some credo warnings.