Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to create a Elm package #126

Merged
merged 3 commits into from
Jan 14, 2022
Merged

How to create a Elm package #126

merged 3 commits into from
Jan 14, 2022

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Dec 3, 2018

@SimonLab SimonLab self-assigned this Dec 3, 2018
@nelsonic
Copy link
Member

@SimonLab it would be a amaze to get this ready at some point (soon) for others to benefit from! 😉

@@ -0,0 +1,238 @@
# What
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider moving this file to /tutorials/elm-package/README.md as the /examples is more for basic code examples whereas /tutorials appears to be for more long-form step-by-step walk through.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Arhell thanks for reading through the PR and the reminder that we should merge this.
Happy for my review comments to be address in a future PR. 👍

Once again, superb effort @SimonLab 🎉

@nelsonic nelsonic merged commit dd99bc7 into master Jan 14, 2022
@nelsonic nelsonic deleted the elm-package branch January 14, 2022 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants