Mark 0

[jrans]

THIS PR

README says it all tbh but basically first attempt at modularising the db part of our abase ideas.

Most of this code has already been added to abase master so copying it out and making it more accessible.

The bits that need to be reviewed therefore are how the api is exposed and plugin setup but actual SQL gen and base handlers the same.

Resolves: #2
Resolves: #3
Resolves: #5
Resolves: #6
Resolves: #7
Resolves: #8
Resolves: #9
Resolves: #10
Resolves: #11

[nelsonic]

@jrans does https://github.com/air-supply/alpha/pull/56 depend on this?

[jrans]

@nelsonic yes! But its published on npm already...

[jrans]

@eliasCodes @SimonLab @Shouston3 @jackcarlisle tagging you here to have a look comment too! Be really cool if you guys started using in your projects and improving! ALso getting the other modules working, i.e. validation, view.. would be cool too and then to sort out the mother module...

[eliasmalik]

@jrans looks good. Still got the #joi-postgresql header in the README though, is that on purpose?

[samhstn]

@jrans Great read, loving the clean, dry, es5 code and lack of dependencies.

Sorry for being pedantic, but could you just clarify the use of the Object.assign.

I thought that we were not using that syntax (at least from my interpretation of this goodparts issue)

...but that line isn't failing your linter despite having ecmaVersion: 5 in your .eslintrc

[jrans]

@eliasCodes yes not sure whats happening with the repo name so left it...
@Shouston3 aha must of slipped in! Yes linter doesn't pick it up. Will make the fix soon..

[nelsonic]

@jrans can I merge this PR into master so people who see this repo have something to look at?

[jrans]

@nelsonic yes that would be really cool, if all is good with you! Now that there is the base, it has been really easy to iterate features with just a couple of extra lines of code so we can quite quickly make changes when needed!

[nelsonic]

merging. 🎉