Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove symlinking #269

Merged
merged 7 commits into from
Nov 5, 2016
Merged

Remove symlinking #269

merged 7 commits into from
Nov 5, 2016

Conversation

eliasmalik
Copy link
Contributor

Related to #248

So thanks to #267 I finally got round to writing enough tests for this to be worth PR-ing.

Major Changes

  • Post-install script removed; default behaviour on install no is no longer to create a symlinked .eslintrc.js file
  • CLI flag --link added to still allow symlink to be generated if user wishes
  • Tests added for --link and --fix flags

Minor Changes

  • README updated to explain --link and --fix usage

Not a particularly urgent PR. Also I'm thinking this PR should bump us up to 1.2.0 rather than 1.1.5 since its a change in behaviour, but open to suggestions.

@nelsonic
Copy link
Member

nelsonic commented Nov 5, 2016

@eliasCodes code looks good. thanks for making the time to update this. 👍
Please publish a new version on using the following:

git checkout master
git pull
npm version minor -m 'make symlink optional - no functional changes'
git push && git push --tags
npm publish

@nelsonic nelsonic merged commit 380e412 into master Nov 5, 2016
@nelsonic nelsonic deleted the remove-symlinking branch November 5, 2016 14:50
@eliasmalik
Copy link
Contributor Author

@nelsonic done 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants