Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "test elias rules" #227

Merged
merged 1 commit into from
Sep 23, 2016
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 0 additions & 11 deletions rules/node_common_js.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,2 @@
module.exports = {
"no-sync": "off", // https://github.com/dwyl/goodparts/issues/144
"no-restricted-properties": "off", // https://github.com/dwyl/goodparts/issues/143
"no-restricted-modules": "off", // https://github.com/dwyl/goodparts/issues/139
"no-process-exit": "error", // https://github.com/dwyl/goodparts/issues/136
"no-process-env": "off", // https://github.com/dwyl/goodparts/issues/134
"no-path-concat": "error", // https://github.com/dwyl/goodparts/issues/132
"no-new-require": "error", // https://github.com/dwyl/goodparts/issues/129
"no-mixed-requires": ["error", { "grouping": true, "allowCall": false }], // https://github.com/dwyl/goodparts/issues/126
"handle-callback-err": ["error", "^(error|err\d*)$"], // https://github.com/dwyl/goodparts/issues/121
"global-require": "error", // https://github.com/dwyl/goodparts/issues/119
"callback-return": ["error", ["done", "next", "callback", "cb"]], // https://github.com/dwyl/goodparts/issues/112
};
28 changes: 0 additions & 28 deletions rules/stylistic_issues.js
Original file line number Diff line number Diff line change
@@ -1,33 +1,5 @@
module.exports = {
"space-infix-ops": ["error", {"int32Hint": false}], // https://github.com/dwyl/goodparts/issues/32
"max-len": ["error", 80], // https://github.com/dwyl/goodparts/issues/186
"array-bracket-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/219
"block-spacing": "error", // https://github.com/dwyl/goodparts/issues/218
"brace-style": ["error", "1tbs", { "allowSingleLine": true }], // https://github.com/dwyl/goodparts/issues/217
"camelcase": "error", // https://github.com/dwyl/goodparts/issues/216
"comma-style": ["error", "last"], // https://github.com/dwyl/goodparts/issues/215
"comma-spacing": ["error", { "before": false, "after": true }], // https://github.com/dwyl/goodparts/issues/214
"comma-dangle": ["error", "never"], // https://github.com/dwyl/goodparts/issues/213
"computed-property-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/212
"consistent-this": "off", // https://github.com/dwyl/goodparts/issues/211
"eol-last": "error", // https://github.com/dwyl/goodparts/issues/210
"func-call-spacing": ["error", "never"], // https://github.com/dwyl/goodparts/issues/209
"func-names": "off", // https://github.com/dwyl/goodparts/issues/208
"func-style": "off", // https://github.com/dwyl/goodparts/issues/207
"id-blacklist": "off", // https://github.com/dwyl/goodparts/issues/205
"id-length": "off", // https://github.com/dwyl/goodparts/issues/204
"id-match": "off", // https://github.com/dwyl/goodparts/issues/202
"indent": ["error", 4], // https://github.com/dwyl/goodparts/issues/201
"jsx-quotes": "off", // https://github.com/dwyl/goodparts/issues/199
"padded-blocks": ["error", "never"], // https://github.com/dwyl/goodparts/issues/55
"quote-props": ["error", "consistent-as-needed", { "keywords": false }], // https://github.com/dwyl/goodparts/issues/54
"quotes": ["error", "single", {"avoidEscape": false, "allowTemplateLiterals": false}], // https://github.com/dwyl/goodparts/issues/53
"semi-spacing": ["error", {"before": false, "after": true}], // https://github.com/dwyl/goodparts/issues/50
"sort-keys": "off", // https://github.com/dwyl/goodparts/issues/39
"sort-vars": "off", // https://github.com/dwyl/goodparts/issues/38
"space-in-parens": ["error", "never"], // https://github.com/dwyl/goodparts/issues/34
"spaced-comment": ["error", "always"], // https://github.com/dwyl/goodparts/issues/20
"wrap-regex": "off", // https://github.com/dwyl/goodparts/issues/17
"max-len": ["error", {
code: 80,
ignoreTrailingComments: true,
Expand Down
4 changes: 0 additions & 4 deletions rules/variables.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,2 @@
module.exports = {
"no-use-before-define": "error", // https://github.com/dwyl/goodparts/issues/153
"no-undefined": "error", // https://github.com/dwyl/goodparts/issues/152
"no-undef-init": "error", // https://github.com/dwyl/goodparts/issues/151
"no-shadow-restricted-names": "error", // https://github.com/dwyl/goodparts/issues/150
};
6 changes: 0 additions & 6 deletions test/fixtures/brace-style.fail.js

This file was deleted.

5 changes: 0 additions & 5 deletions test/fixtures/brace-style.pass.js

This file was deleted.

5 changes: 0 additions & 5 deletions test/fixtures/callback-return.fail.js

This file was deleted.

5 changes: 0 additions & 5 deletions test/fixtures/callback-return.pass.js

This file was deleted.

2 changes: 0 additions & 2 deletions test/fixtures/comma-style.fail.js

This file was deleted.

2 changes: 0 additions & 2 deletions test/fixtures/comma-style.pass.js

This file was deleted.

3 changes: 0 additions & 3 deletions test/fixtures/eol.fail.js

This file was deleted.

3 changes: 0 additions & 3 deletions test/fixtures/eol.pass.js

This file was deleted.

5 changes: 0 additions & 5 deletions test/fixtures/global-require.fail.js

This file was deleted.

3 changes: 0 additions & 3 deletions test/fixtures/handle-callback-err.fail.js

This file was deleted.

6 changes: 0 additions & 6 deletions test/fixtures/handle-callback-err.pass.js

This file was deleted.

6 changes: 0 additions & 6 deletions test/fixtures/ident.fail.js

This file was deleted.

6 changes: 0 additions & 6 deletions test/fixtures/ident.pass.js

This file was deleted.

2 changes: 0 additions & 2 deletions test/fixtures/no-mixed-requires.fail.js

This file was deleted.

2 changes: 0 additions & 2 deletions test/fixtures/no-use-before-define.fail.js

This file was deleted.

2 changes: 0 additions & 2 deletions test/fixtures/no-use-before-define.pass.js

This file was deleted.

30 changes: 1 addition & 29 deletions test/fixtures/node_common_js.js
Original file line number Diff line number Diff line change
@@ -1,31 +1,3 @@
var read = require('../read.js');

module.exports = {
'no-sync': null,
'no-restricted-properties': null,
'no-restricted-modules': null,
'no-process-exit': {
fail: ['process.exit(1);']
},
'no-process-env': null,
'no-path-concat': {
fail: ['var fullPath = __dirname + "/foo.js";']
},
'no-new-require': {
fail: ['var mod = new require("mod");']
},
'no-mixed-requires': {
fail: [read('no-mixed-requires.fail')],
},
'handle-callback-err': {
fail: [read('handle-callback-err.fail')],
pass: [read('handle-callback-err.pass')]
},
'global-require': {
fail: [read('global-require.fail')]
},
'callback-return': {
fail: [read('callback-return.fail')],
pass: [read('callback-return.pass')]
}
};
module.exports = {};
5 changes: 0 additions & 5 deletions test/fixtures/padded-blocks.fail.js

This file was deleted.

3 changes: 0 additions & 3 deletions test/fixtures/padded-blocks.pass.js

This file was deleted.

4 changes: 0 additions & 4 deletions test/fixtures/quote-props.fail.js

This file was deleted.

4 changes: 0 additions & 4 deletions test/fixtures/quote-props.pass.js

This file was deleted.

1 change: 0 additions & 1 deletion test/fixtures/quotes.fail.js

This file was deleted.

1 change: 0 additions & 1 deletion test/fixtures/quotes.pass.js

This file was deleted.

80 changes: 1 addition & 79 deletions test/fixtures/stylistic_issues.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,83 +8,5 @@ module.exports = {
'space-infix-ops': {
fail: ['var a = 1+ 2;'],
pass: ['var a = 1 + 2;']
},
'array-bracket-spacing': {
fail: ['[ 1, 2, 3 ]'],
pass: ['[1, 2, 3]']
},
'block-spacing': {
fail: ['{var a =2; }'],
pass: ['{var a =2;}']
},
'brace-style': {
fail: [read('brace-style.fail')],
pass: [read('brace-style.pass')]
},
'camelcase': {
fail: ['var camel_case = 42;'],
pass: ['var camelCase = 42;']
},
'comma-style': {
fail: [read('comma-style.fail')],
pass: [read('comma-style.pass')]
},
'comma-spacing': {
fail: ['var a = 2 , b = 3;'],
pass: ['var a = 2, b = 3;']
},
'comma-dangle': {
fail: ['var a = [1, 2,];'],
pass: ['var a = [1, 2];']
},
'computed-property-spacing': {
fail: ['obj[ "foo" ];'],
pass: ['obj["foo"];']
},
'consistent-this': null,
'eol-last': {
fail: [read('eol.fail')],
pass: [read('eol.pass')]
},
'func-call-spacing': {
fail: ['fn ();'],
pass: ['fn();']
},
'func-names': null,
'func-style': null,
'id-blacklist': null,
'id-length': null,
'id-match': null,
'indent': {
fail: [read('ident.fail')],
pass: [read('ident.pass')]
},
'jsx-quotes': null,
'padded-blocks': {
fail: [read('padded-blocks.fail')],
pass: [read('padded-blocks.pass')]
},
'quote-props': {
fail: [read('quote-props.fail')],
pass: [read('quote-props.pass')]
},
'quotes': {
fail: [read('quotes.fail')],
pass: [read('quotes.pass')]
},
'semi-spacing': {
fail: ['var a = 2 ;', 'var foo;var bar;'],
pass: ['var a = 2;', 'var foo; var bar;']
},
'sort-keys': null,
'sort-vars': null,
'space-in-parens': {
fail: ['foo( "bar" );'],
pass: ['foo("ba");']
},
'spaced-comment': {
fail: ['//no space'],
pass: ['// yes!']
},
'wrap-regex': null
}
};
17 changes: 1 addition & 16 deletions test/fixtures/variables.js
Original file line number Diff line number Diff line change
@@ -1,18 +1,3 @@
var read = require('../read.js');

module.exports = {
'no-use-before-define': {
fail: [read('no-use-before-define.fail')],
pass: [read('no-use-before-define.pass')]
},
'no-undefined': {
fail: ['var undefined = "bob";']
},
'no-undef-init': {
fail: ['var a = undefined;'],
pass: ['var a;']
},
'no-shadow-restricted-names': {
fail: ['function NaN(){};']
}
};
module.exports = {};