test elias rules #222
Merged
test elias rules #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@SimonLab Can you reference the issues that this PR resolves? so once merged will close them all. |
jrans
requested changes
Sep 23, 2016
| @@ -1,5 +1,33 @@ | |||
| module.exports = { | |||
| "space-infix-ops": ["error", {"int32Hint": false}], // https://github.com/dwyl/goodparts/issues/32 | |||
| "max-len": ["error", 80], // https://github.com/dwyl/goodparts/issues/186 | |||
There was a problem hiding this comment.
remove this one as other is more exact
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ready for review!
related to:
Resolves #219
Resolves #218
Resolves #217
Resolves #216
Resolves #215
Resolves #214
Resolves #213
Resolves #212
Resolves #211
Resolves #210
Resolves #209
Resolves #208
Resolves #207
Resolves #205
Resolves #204
Resolves #202
Resolves #201
Resolves #199
Resolves #186
Resolves #153
Resolves #152
Resolves #151
Resolves #150
Resolves #144
Resolves #143
Resolves #139
Resolves #136
Resolves #134
Resolves #132
Resolves #129
Resolves #126
Resolves #121
Resolves #119
Resolves #112
Resolves #55
Resolves #54
Resolves #53
Resolves #50
Resolves #39
Resolves #38
Resolves #34
Resolves #32
Resolves #20
Resolves #17