Merge pull request #262 from dwyl/no-useless-return

add no-useless-return rule

package.json

@@ -1,7 +1,7 @@
 {
   "name": "goodparts",
   "description": "An ESLint Style that only allows JavaScript the Good Parts (and \"Better Parts\") in your codebase.",
-  "version": "1.1.2",
+  "version": "1.1.3",
   "main": ".eslintrc.js",
   "scripts": {
     "test": "tape test/index.js",
@@ -15,7 +15,7 @@
     "tape": "^4.6.0"
   },
   "dependencies": {
-    "eslint": "^3.6.1"
+    "eslint": "^3.9.1"
   },
   "bin": "./bin/cmd.js",
   "contributors": [

rules/best_practices.js

@@ -65,5 +65,6 @@ module.exports = {
   'no-useless-escape': 'error', // https://github.com/dwyl/goodparts/issues/116
   'no-warning-comments': 'off', // https://github.com/dwyl/goodparts/issues/117
   'radix': ['error', 'always'], // https://github.com/dwyl/goodparts/issues/118
-  'wrap-iife': ['error', 'inside'] // https://github.com/dwyl/goodparts/issues/124
+  'wrap-iife': ['error', 'inside'], // https://github.com/dwyl/goodparts/issues/124
+  'no-useless-return': 'error' // https://github.com/dwyl/goodparts/issues/261
 };

test/fixtures/best_practices.js

@@ -250,5 +250,9 @@ module.exports = {
   'no-useless-call': { fail: ['foo.call(null, 1, 2, 3);'] },
   'no-useless-escape': { fail: ['"\\a";'] },
   'no-warning-comments': null,
-  'radix': { fail: ['var num = parseInt("071'] }
+  'radix': { fail: ['var num = parseInt("071'] },
+  'no-useless-return': {
+    fail: [read('./no-useless-return.fail')],
+    pass: [read('./no-useless-return.pass')]
+  }
 };

test/fixtures/no-useless-return.fail.js

@@ -0,0 +1 @@
+function foo() { return; }

test/fixtures/no-useless-return.pass.js

@@ -0,0 +1 @@
+function foo() { return 5; }