-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PR] Adding dynamic menu #5
Conversation
I've managed to get the contents of |
In principal we will use the same |
Reordering should now work locally. Meaning it is not saving the changes to the Screen.Recording.2023-04-28.at.20.04.30.mov |
Missing root objects.
I've managed to increase the code coverage to near 98%. Will tackle on getting it to 100%. I've successfully tested dragging and dropping. Flutter's |
Fixed a few bugs regarding reordering and fixed the decoration border that was overlapping on nested elements. Added both of these to the README. Not yet marking this for review because I want to add a simple navigation to a page displaying the menu item information. After that, everything should be thoroughly documented and ready for submission. |
This should be done for review. Added navigation, tests to cover the full app and added a CI to fix typos on a separate PR. Because the changes added are substantial, there's a chance I got a typo here and there. |
@LuchoTurtle could you please record a short video/GIF of the final result. 🎥 |
Screen.Recording.2023-05-12.at.09.57.19.movHere's an overview:
|
Could this PR be merged? I believe it's complete and easily mergeable 🆗 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I reviewed it at the time. 👀
Had asked @SimonLab to have a look, but I think he's focussed on other priority items. 👌
Merging. ✅
closes #4
This PR adds a menu that is dynamic, meaning it uses the information stemming from a
json
object to render the contents.The
json
object consists ofMenuItems
(with an id, title and tiles - a list ofMenuItems
below).