Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Readme #7

Merged
merged 1 commit into from
Dec 7, 2018
Merged

update Readme #7

merged 1 commit into from
Dec 7, 2018

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Dec 7, 2018

ref: #6

  • Update README before publishing package
  • Add LICENSE file

@SimonLab SimonLab requested a review from nelsonic December 7, 2018 04:34
nelsonic
nelsonic reviewed Dec 7, 2018
View reviewed changes
README.md
## Examples

[example](https://dwyl.github.io/elm-criteria/example.html)
See a [live example](https://dwyl.github.io/elm-criteria/example.html) and its [code]()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remember to update the direct link to the code for the example. 👍🏻

nelsonic
nelsonic approved these changes Dec 7, 2018
View reviewed changes
Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good.
We don’t “normally” use BSD license, but I have no “objection”.
Happy to merge.
Thanks! 🙌

@nelsonic nelsonic merged commit 27f7d96 into master Dec 7, 2018
@nelsonic nelsonic deleted the update-doc-publish branch December 7, 2018 09:17
@SimonLab
Copy link
Member Author

SimonLab commented Dec 7, 2018

Thanks for the review/merge @nelsonic
I wasn't sure which license to use but saw that BSD was mostly used with Elm package and was recommended. We can review it later if necessary 👍

@nelsonic
Copy link
Member

nelsonic commented Dec 7, 2018

@SimonLab yeah, BSD is a good license.
We tend to use GPL-2 see: https://github.com/dwyl/intellectual-property
Elm package is recommending a more "permissive" license. No need to change.
Thanks for moving fast with this project. ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nelsonic nelsonic nelsonic approved these changes

Assignees

@nelsonic nelsonic

Labels
awaiting-review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonLab @nelsonic