Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean code and initialise dwylbot github app #53

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

SimonLab
Copy link
Member

@SimonLab SimonLab commented Jun 7, 2017

see #51 and #30

This PR delete some code which is not relevant anymore due to the use of a Github App instead of a traditional OAuth App.
This PR also create an endpoint /installation which will display the list of organisation and repositories where dwylbot is installed (see #52 )

@codecov
Copy link

codecov bot commented Jun 7, 2017

Codecov Report

Merging #53 into master will increase coverage by 10.67%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master      #53       +/-   ##
===========================================
+ Coverage    74.5%   85.18%   +10.67%     
===========================================
  Files           9        8        -1     
  Lines          51       27       -24     
===========================================
- Hits           38       23       -15     
+ Misses         13        4        -9
Impacted Files Coverage Δ
web/router.ex 50% <ø> (-50%) ⬇️
web/controllers/installation_controller.ex 100% <100%> (ø)
web/controllers/auth.ex 100% <0%> (+12.5%) ⬆️
web/models/user.ex 100% <0%> (+50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdd2866...5ae4770. Read the comment docs.

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SimonLab looks good. 🎉

@nelsonic nelsonic removed their assignment Jun 7, 2017
Copy link
Member

@Danwhy Danwhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@samhstn samhstn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@samhstn samhstn merged commit e351711 into master Jun 7, 2017
@samhstn samhstn deleted the initialise_github_app branch June 7, 2017 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants