Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new api based on OAuth of Github Apps credentials #52

Closed
3 tasks done
SimonLab opened this issue Jun 5, 2017 · 1 comment
Closed
3 tasks done

Use new api based on OAuth of Github Apps credentials #52

SimonLab opened this issue Jun 5, 2017 · 1 comment

Comments

@SimonLab
Copy link
Member

SimonLab commented Jun 5, 2017

When moving dwylbot to a Github App (see #51), Github provides new credentials for OAuth. This new credentials don't allow us to access as much api endpoints as before:
image
Here we can't get the list of the public repos of the logged in user anymore. Instead of getting the list of public repos I suggest to follow the userflow described here.
So the first step after login is to display the list of all installations of dwylbot available to the user by using the following endpoint: https://developer.github.com/v3/apps/#list-installations-for-user.

  • Create a simple http client for Github app that allow us to send api request to this new endpoint (Tentacat doesn't implement at this stage the api for Github Apps, linked to Replace Tentacat by HTTPoison #25 )
  • Could we use a dumb Github App to run our tests or should we create a mock?
  • Display the json response on the website
@ghost
Copy link

ghost commented Jun 13, 2017

This works

@ghost ghost closed this as completed Jun 13, 2017
@jammur jammur unassigned ghost Dec 14, 2017
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant