-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initialise Flutter application #302
Conversation
- Run `flutter create .` to create a new flutter application on the current folder - Update the existing .gitignore file with the one created by the flutter command
- dispalye textField and list of items - Attempt to expands the textField
Thanks for proactively looking at this @SimonLab 👍 |
Wrap TextField widget in a Focus widget to be able to use the onFocusChange callback. see #308
@SimonLab do you feel like this is at a point where it can be reviewed & merged into Asking because the work @LuchoTurtle did for the Basic Nav #305 should be ready to integrate into the |
Commend list of items to unblock Luis
To unblock the work from @LuchoTurtle I think we can merge this PR. |
Will check the code. Just waiting for VSCode to download everything. I needed to run |
The test is failing. I'm going to create a simple setup one with CI so this PR already has a pipeline when merged 🙂 |
- package-ecosystem: mix | ||
directory: "/" | ||
schedule: | ||
interval: daily |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can make the interval weekly. We have a lot of notifications for updating the dependencies on the repositories and this creates a lot of noise. But happy to keep it daily on specific repositories too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still not sure if this should be daily or weekly for this repo. While this repo is in active development we might want to keep it daily, I was more thinking of other "stable" repos.
We can change this back on the next PRs if required
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll leave this open for @nelsonic to comment. I'll change it back to daily, meanwhile.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally happy with Weekly for the demo/example. Agree that it's noisy. Let's start changing the frequency gradually on all those our repos. However on the App
and Auth
we want daily to for security updates. 💭
To get this merged ASAP, lgtm! Coverage is not 100% (it's still being developed by you, you can get it up in a different branch) and the README will obviously be extended. But for now, it's good to start to get some work on, I wager. Thanks @SimonLab 🎉 |
|
||
defaultConfig { | ||
// TODO: Specify your own unique Application ID (https://developer.android.com/studio/build/application-id.html). | ||
applicationId "com.example.app" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many instances of "com.example.app"
in this PR.
We need to update them all to "com.dwyl.app"
see: #312
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
flutter create .
to create a new flutter application on the current folder