Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changesets #23

Merged
merged 4 commits into from
Dec 6, 2018
Merged

Changesets #23

merged 4 commits into from
Dec 6, 2018

Conversation

Danwhy
Copy link
Member

@Danwhy Danwhy commented Dec 6, 2018

"""
def insert(attrs) do
%__MODULE__{}
def insert(struct_or_changeset) do
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. 👍

Copy link
Member

@nelsonic nelsonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Danwhy tests and code for Changesets looks great! thanks! 👍

@nelsonic nelsonic merged commit 95bd86f into master Dec 6, 2018
@nelsonic nelsonic deleted the changesets branch December 6, 2018 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants