Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CSP policy #9836

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Update CSP policy #9836

merged 3 commits into from
Jan 9, 2025

Conversation

spolu
Copy link
Contributor

@spolu spolu commented Jan 8, 2025

Description

For https://github.com/dust-tt/tasks/issues/1894

Stricten our CSP policy. Tesed in dev.
Viz is OK with this cc @fontanierh & @flvndvd
This is not absolutely great as we will have errors as we add new style or script integrations.
The script-src setting is supposed to be nextJS friendly and was tested locally
Will deploy to front-edge and test there before merging

Risk

High but easy to revert

Deploy Plan

  • deploy to front-edge and test
  • deploy front

@spolu spolu requested a review from PopDaph January 8, 2025 15:34
Copy link
Contributor

@PopDaph PopDaph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trusting you with the implications of this one!

@spolu
Copy link
Contributor Author

spolu commented Jan 9, 2025

Tested on front-edge moving forward with this

@spolu spolu merged commit 128d7da into main Jan 9, 2025
8 checks passed
@spolu spolu deleted the spolu-csp branch January 9, 2025 12:37
@spolu
Copy link
Contributor Author

spolu commented Jan 9, 2025

Was not able to enforce a default-src without issue. Hopefully it will be enough for the scan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants