Fix Dialog change assistant scope not working #9834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Runner card: https://github.com/dust-tt/tasks/issues/1921
Migrating the Dialog displayed when we try to change the scope of an assistant, since it's open from a modal and the modal has been migrated to Radix, we need to use NewDialog that is also based on radix.
Note: there's a glitch if we try to re-render the Dialog if we've already done it and there's a notification rendered. When the notification disappear, it closes the Dialog. Most likely because Notification also need to be moved to Radix.
Risk
Break the dialog? But was already broken.
Can be rolled back.
Deploy Plan
Deploy front.