Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confluence error handling: catch fetch aborts #4979

Merged
merged 1 commit into from
May 6, 2024

Conversation

philipperolet
Copy link
Contributor

Description

Those errors occur on the confluence connector when fetch is aborted. Apparently a timeout can cause either an "AbortError" or a "TimeoutError"

nodejs/node#43874

Risk & deploy NTR

Description
---
Those errors occur on the confluence connector when fetch is
aborted. Apparently a timeout can cause either an "AbortError" or a
"TimeoutError"

nodejs/node#43874
@philipperolet philipperolet requested a review from fontanierh May 6, 2024 07:32
@philipperolet
Copy link
Contributor Author

PMRR

@philipperolet philipperolet merged commit 89d7711 into main May 6, 2024
3 checks passed
@philipperolet philipperolet deleted the err-handling-confl branch May 6, 2024 07:33
Copy link
Contributor

@fontanierh fontanierh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

flvndvd pushed a commit that referenced this pull request May 26, 2024
Description
---
Those errors occur on the confluence connector when fetch is
aborted. Apparently a timeout can cause either an "AbortError" or a
"TimeoutError"

nodejs/node#43874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants