DUPLO-17985: Updated logger to not print Log Level #107
+95
−91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
kferrone
requested changes
Oct 10, 2024
| @@ -316,7 +316,7 @@ def logger_for(self, name: str=None) -> logging.Logger: | |||
| logger = logging.getLogger(name) | |||
| lvl = logging.getLevelName(self.loglevel) | |||
| logger.setLevel(lvl) | |||
| formatter = logging.Formatter("%(levelname)s %(message)s") | |||
| formatter = logging.Formatter("%(message)s") | |||
There was a problem hiding this comment.
Pretty sure this will affect all of the logs, not just the pod logs. I would prefer having a seperate logger for the pod logs. Then a logger for normal logs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe Changes
Updated logger to not print Log Level as it was getting annoying for users to see:
Link to Issues
PR Review Checklist
Testing
Before Fix
After Fix
