Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Share URL configurable #523

Merged
merged 1 commit into from
Dec 23, 2024
Merged

Conversation

anishsheela
Copy link
Contributor

Currently the share URL domain in the profile is not configurable. This creates a new environment variable and remove the hardcoding.

Copy link
Member

@duogenesis duogenesis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for improving this. Just one small change then we can merge

env/env.tsx Outdated Show resolved Hide resolved
@anishsheela
Copy link
Contributor Author

Pushed with changes. Please review.

@duogenesis duogenesis merged commit 45f43a0 into duolicious:main Dec 23, 2024
1 of 2 checks passed
@anishsheela anishsheela deleted the share_url branch December 23, 2024 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants