ensure php-self is normalized #1136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -176,6 +176,53 @@ func testServerVariable(t *testing.T, opts *testOptions) { | |||
| }, opts) | |||
| } | |||
|
|
|||
| func TestUnusualServerVariable_module(t *testing.T) { | |||
There was a problem hiding this comment.
I wonder if the result of this test would be the same if it was done with caddy_test
|
While the patch doesn't seem to do any harm, to be honest, I don't understand exactly what it fixes. Does it make the behavior similar to FPM? |
|
For Caddy, there is no change. This is only required for non-caddy usages of FrankenPHP. I'd be happy just documenting it, if that makes more sense. It appears that this causes a small performance hit and I suspect most people are using Caddy + FrankenPHP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this closes #1133