Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release PR] Update VPN localization #3675

Merged
merged 6 commits into from
Dec 19, 2024

Conversation

samsymons
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1207941519901927/1209009536812109/f
Tech Design URL:
CC:

Description:

This PR updates VPN localization to fix an issue on macOS 11 and 12.

Optional E2E tests:

  • Run PIR E2E tests
    Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:

  1. Check that localization on modern OS versions looks correct
  2. If possible, test on macOS 12 - but in case this isn't possible, I've attached a screenshot of this being fixed in a macOS 12 VM

CleanShot 2024-12-18 at 11 36 37@2x

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@samsymons samsymons requested a review from miasma13 December 18, 2024 19:38
@samsymons samsymons changed the base branch from main to release/1.119.0 December 18, 2024 19:38
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I just added at least a single translated string to those en-US variants.

@samsymons samsymons merged commit 1aa4e51 into release/1.119.0 Dec 19, 2024
30 checks passed
@samsymons samsymons deleted the sam/release-pr-fix-vpn-localization branch December 19, 2024 01:42
samsymons added a commit that referenced this pull request Dec 19, 2024
Task/Issue URL: https://app.asana.com/0/1207941519901927/1209009536812109/f
Tech Design URL:
CC:

Description:

This PR updates VPN localization to fix an issue on macOS 11 and 12.
samsymons added a commit that referenced this pull request Dec 19, 2024
* main:
  Bump version to 1.119.0 (332)
  Update to Privacy Pro settings footer (#3679)
  [Release PR] Update VPN localization (#3675)
samsymons added a commit that referenced this pull request Dec 19, 2024
# By Anka (2) and others
* hotfix/1.118.1:
  Update to Privacy Pro settings footer (#3679)
  [Release PR] Update VPN localization (#3675)
  Bump version to 1.118.1 (331)
  Set marketing version to 1.118.1

# Conflicts:
#	Configuration/BuildNumber.xcconfig
#	Configuration/Version.xcconfig
samsymons added a commit that referenced this pull request Dec 19, 2024
* main:
  CRCID Support when reporting crashes (#3653)
  Bump version to 1.119.0 (332)
  Update to Privacy Pro settings footer (#3679)
  Update to Privacy Pro settings footer (#3679)
  [Release PR] Update VPN localization (#3675)
  Bump version to 1.118.1 (331)
  Set marketing version to 1.118.1
  [Release PR] Update VPN localization (#3675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants