Avoid Fireproofing the same website multiple times (#288)

* Prevent duplicate Fireproof domains from being added. * Commit a BSK revision bump.
duckduckgo · Oct 29, 2021 · 53b287d · 53b287d
1 parent 3e77bd6
commit 53b287d
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/DuckDuckGo/Fireproofing/Model/FireproofDomains.swift b/DuckDuckGo/Fireproofing/Model/FireproofDomains.swift
@@ -46,6 +46,10 @@ internal class FireproofDomains {
     }
 
     func addToAllowed(domain: String) {
+        guard !isFireproof(fireproofDomain: domain) else {
+            return
+        }
+
         fireproofDomains += [domain]
 
         NotificationCenter.default.post(name: Constants.newFireproofDomainNotification, object: self, userInfo: [

diff --git a/Unit Tests/Fireproofing/FireproofDomainsTests.swift b/Unit Tests/Fireproofing/FireproofDomainsTests.swift
@@ -60,4 +60,19 @@ final class FireproofDomainsTests: XCTestCase {
         XCTAssertTrue(logins.fireproofDomains.isEmpty)
     }
 
+    func testWhenAddingDuplicateDomainsThenSubsequentDomainsAreIgnored() {
+        let domain = "example.com"
+        let logins = FireproofDomains()
+        logins.addToAllowed(domain: domain)
+        XCTAssertTrue(logins.isFireproof(fireproofDomain: domain))
+
+        logins.addToAllowed(domain: domain)
+        XCTAssertTrue(logins.isFireproof(fireproofDomain: domain))
+        XCTAssertEqual(logins.fireproofDomains, [domain])
+
+        logins.remove(domain: domain)
+        XCTAssertFalse(logins.isFireproof(fireproofDomain: domain))
+        XCTAssertEqual(logins.fireproofDomains, [])
+    }
+
 }