Ensure tab state is torn down on window close #13049
Annotations
5 errors and 12 warnings
Run integration tests:
IntegrationTests/Tab/AddressBarTests.swift#L772
testWhenActivatingWindowWithPinnedTabOpen_webViewBecomesFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_Privacy_Browser.MainWindow: 0x125fada60>)") is not equal to ("Optional(<DuckDuckGo_WebView: 0x12708a010>)")
|
Run integration tests:
IntegrationTests/Tab/AddressBarTests.swift#L773
testWhenActivatingWindowWithPinnedTabOpen_webViewBecomesFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_WebView: 0x12708a010>)") is not equal to ("Optional(<DuckDuckGo_Privacy_Browser.MainWindow: 0x125fb9190>)")
|
Run integration tests:
IntegrationTests/Tab/AddressBarTests.swift#L772
testWhenActivatingWindowWithPinnedTabOpen_webViewBecomesFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_Privacy_Browser.MainWindow: 0x168864b10>)") is not equal to ("Optional(<DuckDuckGo_WebView: 0x1271fdb40>)")
|
Run integration tests:
IntegrationTests/Tab/AddressBarTests.swift#L773
testWhenActivatingWindowWithPinnedTabOpen_webViewBecomesFirstResponder, XCTAssertEqual failed: ("Optional(<DuckDuckGo_WebView: 0x1271fdb40>)") is not equal to ("Optional(<DuckDuckGo_Privacy_Browser.MainWindow: 0x122fb0360>)")
|
Run integration tests:
IntegrationTests/Tab/AddressBarTests.swift#L314
testWhenSwitchingBetweenTabsWithTypedValue_typedValueIsPreserved, XCTAssertEqual failed: ("https://duckduckgo.com/") is not equal to ("tab-6")
|
The following actions use a deprecated Node.js version and will be forced to run on node20: webfactory/[email protected]. For more info: https://github.blog/changelog/2024-03-07-github-actions-all-actions-will-run-on-node20-instead-of-node16-by-default/
|
Run integration tests
sandbox-test-tool isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'sandbox-test-tool' from project 'DuckDuckGo')
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L144
'VPNLogger' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L161
'log(_:server:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L194
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L214
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L231
'log' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L247
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L267
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L287
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L307
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Build and run unit tests:
DuckDuckGo/NetworkProtection/NetworkExtensionTargets/NetworkExtensionTargets/MacPacketTunnelProvider.swift#L327
'log(_:named:)' is deprecated: This goes against Apple logging guidelines and will be removed, please don't use it anymore
|
Loading