Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recovery for users impacted by enabling the credential extension before app migration on app version 7.149.0 #3754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Dec 20, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1209005320461774/f
Tech Design URL:
CC:

Description:
Recovers the passwords vault of any users impacted by edge case scenario of enabling the credential provider extension before the app has perform the migration

Steps to test this PR:

  1. Starting with your existing app build on device which has some passwords saved, run up the app from the branch and confirm all your passwords are all present
  2. Turn DDG off as a system credential provider
  3. Now we are going to reset your state for testing upgrading from an old app version
  4. Download this adhoc build that will allow you to reset in order to downgrade properly
  5. Go to the Debug screen > Keychain Items and tap the button at the top right to remove all v4 migrated data
  6. Downgrade to an older version of the app via TestFlight
  7. Save some passwords for e.g autofill.me
  8. Now upgrade to the problematic app version 7.149.0 (3) from TestFlight but do NOT launch the app
  9. Enable the app as a system credential provider and tap through to view your passwords and confirm they have vanished
  10. Run up this branch again and confirm your passwords are now back!

<!—
Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you know do not need explicit testing.

Using a simulator where a physical device is unavailable is acceptable.
—>

Definition of Done (Internal Only):

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 15
  • iOS 16
  • iOS 17

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

…e the app could perform migration on app version 7.149.0
@amddg44 amddg44 requested a review from aataraxiaa December 20, 2024 13:45
Copy link
Contributor

@aataraxiaa aataraxiaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one @amddg44, tested and recovery works 👍🏼 Approved on the understanding that tests will be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants