Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefill AI Chat with search query #3750

Merged
merged 7 commits into from
Dec 20, 2024
Merged

Prefill AI Chat with search query #3750

merged 7 commits into from
Dec 20, 2024

Conversation

Bunn
Copy link
Contributor

@Bunn Bunn commented Dec 19, 2024

Task/Issue URL: https://app.asana.com/0/1204167627774280/1208991512395320/f

Description:
When opening AI Chat from the address bar, pre-fill it with the SERP query

Steps to test this PR:

  1. Make sure you're set as internal user
  2. Go to the SERP, open AI Chat from the address bar button
  3. Validate that we're pre-filling the AI Chat with the same query
  4. Open AI Chat from the browsing menu button (the ... icon)
  5. Validate that we're NOT pre-filling the AI Chat with the same query

@Bunn Bunn requested a review from afterxleep December 19, 2024 17:51
@afterxleep
Copy link
Collaborator

LGTM, a couple nits in code.

It worked fine in the first search, but if I go back to SERP and search for something else, it does not pre-fill once I go back to AI Chat. Is that expected?

Copy link
Collaborator

@afterxleep afterxleep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a few nits

LocalPackages/AIChat/Sources/AIChat/URL+Extension.swift Outdated Show resolved Hide resolved
LocalPackages/AIChat/Sources/AIChat/URL+Extension.swift Outdated Show resolved Hide resolved
LocalPackages/AIChat/Tests/URLExtensionTests.swift Outdated Show resolved Hide resolved
LocalPackages/AIChat/Tests/URLExtensionTests.swift Outdated Show resolved Hide resolved
@Bunn Bunn merged commit 6b6a223 into main Dec 20, 2024
14 checks passed
@Bunn Bunn deleted the bunn/aichat/prefill branch December 20, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants